From 121fe614999fc1cb4e15679234e4879d1da50987 Mon Sep 17 00:00:00 2001 From: jojohoch <joachim.hoch@iqb.hu-berlin.de> Date: Mon, 12 Dec 2022 16:25:06 +0100 Subject: [PATCH] Set default height of child elements of cloze element to 30 --- docs/release-notes-editor.md | 4 +++- .../cloze/cloze-child-elements/toggle-button.ts | 2 +- .../angular-node-views/button-component-extension.ts | 2 +- .../angular-node-views/toggle-button-component-extension.ts | 4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/release-notes-editor.md b/docs/release-notes-editor.md index 7b0698939..b1d8ff014 100644 --- a/docs/release-notes-editor.md +++ b/docs/release-notes-editor.md @@ -3,8 +3,10 @@ Editor ##1.35.2 ### Verbesserungen - Wendet die Eigenschaft "Schreibgeschützt" auf Formel Elemente an +- Auswahllisten, die nur ein Element zulassen, werden von diesem Element komplett ausgefüllt - Vereinheitlicht das Verhalten von Kindelementen von Lückentexten bei Änderung ihrer Höhe -- Auswahllisten, die nur ein Element zulassen, werden von diesem Element komplett ausgefüllt + Bei Veränderung des Wertes ändert sich die Höhe aus der Mitte heraus +- Setzt bei allen Kindelementen von Lückentexten die Vorbelegung der Höhe auf 30 ## 1.35.1 diff --git a/projects/common/models/elements/compound-elements/cloze/cloze-child-elements/toggle-button.ts b/projects/common/models/elements/compound-elements/cloze/cloze-child-elements/toggle-button.ts index 37e173e17..dd887031a 100644 --- a/projects/common/models/elements/compound-elements/cloze/cloze-child-elements/toggle-button.ts +++ b/projects/common/models/elements/compound-elements/cloze/cloze-child-elements/toggle-button.ts @@ -19,7 +19,7 @@ export class ToggleButtonElement extends InputElement { }; constructor(element: Partial<ToggleButtonElement>) { - super({ height: 25, ...element }); + super({ height: 30, ...element }); if (element.options) this.options = element.options; if (element.strikeOtherOptions) this.strikeOtherOptions = element.strikeOtherOptions; if (element.strikeSelectedOption) this.strikeSelectedOption = element.strikeSelectedOption; diff --git a/projects/editor/src/app/text-editor/angular-node-views/button-component-extension.ts b/projects/editor/src/app/text-editor/angular-node-views/button-component-extension.ts index 6a96ef0e3..1f246db6c 100644 --- a/projects/editor/src/app/text-editor/angular-node-views/button-component-extension.ts +++ b/projects/editor/src/app/text-editor/angular-node-views/button-component-extension.ts @@ -17,7 +17,7 @@ const ButtonComponentExtension = (injector: Injector): Node => { default: new ButtonElement({ type: 'button', id: 'cloze-child-id-placeholder', - height: 34, + height: 30, asLink: true, styling: { backgroundColor: 'transparent' diff --git a/projects/editor/src/app/text-editor/angular-node-views/toggle-button-component-extension.ts b/projects/editor/src/app/text-editor/angular-node-views/toggle-button-component-extension.ts index ca5dc0d9e..482954325 100644 --- a/projects/editor/src/app/text-editor/angular-node-views/toggle-button-component-extension.ts +++ b/projects/editor/src/app/text-editor/angular-node-views/toggle-button-component-extension.ts @@ -2,8 +2,8 @@ import { Injector } from '@angular/core'; import { Node, mergeAttributes } from '@tiptap/core'; import { AngularNodeViewRenderer } from 'ngx-tiptap'; -import { ToggleButtonNodeviewComponent } from './toggle-button-nodeview.component'; import { ToggleButtonElement } from 'common/models/elements/compound-elements/cloze/cloze-child-elements/toggle-button'; +import { ToggleButtonNodeviewComponent } from './toggle-button-nodeview.component'; const ToggleButtonComponentExtension = (injector: Injector): Node => { return Node.create({ @@ -16,7 +16,7 @@ const ToggleButtonComponentExtension = (injector: Injector): Node => { model: { default: new ToggleButtonElement({ type: 'toggle-button', - height: 25, + height: 30, width: 100, id: 'cloze-child-id-placeholder' }) -- GitLab