From 20062df92f5e2b80cacf7c29e33e4252d4ceec3a Mon Sep 17 00:00:00 2001
From: jojohoch <joachim.hoch@iqb.hu-berlin.de>
Date: Fri, 7 Oct 2022 12:24:01 +0200
Subject: [PATCH] Prevent placeholder from protruding in height from a dynamic
drop list
Use a horizontal aligned placeholder for dynamic aligned drop lists
when there is more than one element in the list
---
.../cloze/cloze-child-elements/drop-list-simple.component.ts | 4 ++--
.../common/components/input-elements/drop-list.component.ts | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/projects/common/components/compound-elements/cloze/cloze-child-elements/drop-list-simple.component.ts b/projects/common/components/compound-elements/cloze/cloze-child-elements/drop-list-simple.component.ts
index 345dde6e8..605cf0137 100644
--- a/projects/common/components/compound-elements/cloze/cloze-child-elements/drop-list-simple.component.ts
+++ b/projects/common/components/compound-elements/cloze/cloze-child-elements/drop-list-simple.component.ts
@@ -146,8 +146,8 @@ export class DropListSimpleComponent extends FormElementComponent {
}
setPlaceholderDimensions(itemsCount: number, orientation: unknown): void {
- this.placeholderDimensions.height = itemsCount && orientation === 'vertical' ? 1 : 100;
- this.placeholderDimensions.width = itemsCount && orientation !== 'vertical' ? 1 : 100;
+ this.placeholderDimensions.height = itemsCount && orientation !== 'horizontal' ? 1 : 100;
+ this.placeholderDimensions.width = itemsCount && orientation === 'horizontal' ? 1 : 100;
}
onlyOneItemPredicate = (drag: CdkDrag, drop: CdkDropList): boolean => (
diff --git a/projects/common/components/input-elements/drop-list.component.ts b/projects/common/components/input-elements/drop-list.component.ts
index cbcdc31f5..eaa04a72d 100644
--- a/projects/common/components/input-elements/drop-list.component.ts
+++ b/projects/common/components/input-elements/drop-list.component.ts
@@ -197,8 +197,8 @@ export class DropListComponent extends FormElementComponent {
}
setPlaceholderDimensions(itemsCount: number, orientation: unknown): void {
- this.placeholderDimensions.height = itemsCount && orientation === 'vertical' ? 1 : 100;
- this.placeholderDimensions.width = itemsCount && orientation !== 'vertical' ? 1 : 100;
+ this.placeholderDimensions.height = itemsCount && orientation !== 'horizontal' ? 1 : 100;
+ this.placeholderDimensions.width = itemsCount && orientation === 'horizontal' ? 1 : 100;
}
onlyOneItemPredicate = (drag: CdkDrag, drop: CdkDropList): boolean => (
--
GitLab