From 2bb897b9e7ee48a4241ca697e8c3354fb2ef0134 Mon Sep 17 00:00:00 2001
From: jojohoch <joachim.hoch@iqb.hu-berlin.de>
Date: Thu, 22 Dec 2022 10:48:18 +0100
Subject: [PATCH] [player] Prevent dropping items that do not belong to a drop
 list

#381
---
 docs/release-notes-player.md                                    | 1 +
 .../common/components/input-elements/drop-list.component.ts     | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/release-notes-player.md b/docs/release-notes-player.md
index da7f75f3c..e2b5ca4b2 100644
--- a/docs/release-notes-player.md
+++ b/docs/release-notes-player.md
@@ -9,6 +9,7 @@ Player
 - Speichert Änderungen an GeoGebra-Elementen, die durch Benutzung der 
   Rückgängig- und Wiederherstellen-Knöpfe ausgelöst wurden
 - Korrigiert die Ablegeankündigung für leere Ablegelisten
+- Verhindert das Ablegen von Elementen, die nicht zu einer Ablegeliste gehören
 
 
 ## 1.29.0
diff --git a/projects/common/components/input-elements/drop-list.component.ts b/projects/common/components/input-elements/drop-list.component.ts
index c8a1cb58a..c2832c712 100644
--- a/projects/common/components/input-elements/drop-list.component.ts
+++ b/projects/common/components/input-elements/drop-list.component.ts
@@ -197,7 +197,7 @@ export class DropListComponent extends FormElementComponent implements OnInit, A
   dragEnterList(event: DragEvent) {
     event.preventDefault();
 
-    if (!this.isDropAllowed((DropListComponent.sourceList as DropListComponent).elementModel.connectedTo)) return;
+    if (!DropListComponent.sourceList || !this.isDropAllowed((DropListComponent.sourceList as DropListComponent).elementModel.connectedTo)) return;
 
     if (!this.elementModel.isSortList) {
       this.highlightValidDrop = true;
-- 
GitLab