From c360618ad4e389cc6cc2e2e3e8b94c504d44d9e7 Mon Sep 17 00:00:00 2001
From: rhenck <richard.henck@iqb.hu-berlin.de>
Date: Thu, 28 Oct 2021 15:52:45 +0200
Subject: [PATCH] Remove unused parameter from element constructors
This has been refactored already. Those were not cleaned up properly.
---
projects/common/models/audio-element.ts | 4 ++--
projects/common/models/button-element.ts | 4 ++--
projects/common/models/checkbox-element.ts | 4 ++--
projects/common/models/compound-elements/likert-element.ts | 4 ++--
projects/common/models/dropdown-element.ts | 4 ++--
projects/common/models/image-element.ts | 4 ++--
projects/common/models/radio-button-group-element.ts | 4 ++--
projects/common/models/text-area-element.ts | 4 ++--
projects/common/models/text-element.ts | 4 ++--
projects/common/models/text-field-element.ts | 4 ++--
projects/common/models/uI-element.ts | 6 +++---
projects/common/models/video-element.ts | 4 ++--
12 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/projects/common/models/audio-element.ts b/projects/common/models/audio-element.ts
index 51197f79f..c6b6404c2 100644
--- a/projects/common/models/audio-element.ts
+++ b/projects/common/models/audio-element.ts
@@ -23,8 +23,8 @@ export class AudioElement extends UIElement implements PlayerElement {
showRestTime: boolean = true;
playbackTime: number = 0;
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initPlayerElement(serializedElement));
this.height = serializedElement.height || 90;
diff --git a/projects/common/models/button-element.ts b/projects/common/models/button-element.ts
index 1a9cf0d2c..43389d929 100644
--- a/projects/common/models/button-element.ts
+++ b/projects/common/models/button-element.ts
@@ -18,8 +18,8 @@ export class ButtonElement extends UIElement implements FontElement, SurfaceUIEl
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initFontElement(serializedElement));
Object.assign(this, initSurfaceElement(serializedElement));
diff --git a/projects/common/models/checkbox-element.ts b/projects/common/models/checkbox-element.ts
index ecf0db0ce..67dd466bf 100644
--- a/projects/common/models/checkbox-element.ts
+++ b/projects/common/models/checkbox-element.ts
@@ -13,8 +13,8 @@ export class CheckboxElement extends InputElement implements FontElement, Surfac
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initFontElement(serializedElement));
Object.assign(this, initSurfaceElement(serializedElement));
diff --git a/projects/common/models/compound-elements/likert-element.ts b/projects/common/models/compound-elements/likert-element.ts
index c2711d0bc..8c191f64c 100644
--- a/projects/common/models/compound-elements/likert-element.ts
+++ b/projects/common/models/compound-elements/likert-element.ts
@@ -18,8 +18,8 @@ export class LikertElement extends UIElement implements FontElement, SurfaceUIEl
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initFontElement(serializedElement));
Object.assign(this, initSurfaceElement(serializedElement));
diff --git a/projects/common/models/dropdown-element.ts b/projects/common/models/dropdown-element.ts
index 386f8459b..f8022b38c 100644
--- a/projects/common/models/dropdown-element.ts
+++ b/projects/common/models/dropdown-element.ts
@@ -16,8 +16,8 @@ export class DropdownElement extends InputElement implements FontElement, Surfac
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initFontElement(serializedElement));
Object.assign(this, initSurfaceElement(serializedElement));
diff --git a/projects/common/models/image-element.ts b/projects/common/models/image-element.ts
index 6053216c1..06e8fb9fa 100644
--- a/projects/common/models/image-element.ts
+++ b/projects/common/models/image-element.ts
@@ -2,8 +2,8 @@ import { UIElement } from './uI-element';
export class ImageElement extends UIElement {
src: string = '';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
this.height = serializedElement.height || 100;
}
diff --git a/projects/common/models/radio-button-group-element.ts b/projects/common/models/radio-button-group-element.ts
index b280c06f2..864503cba 100644
--- a/projects/common/models/radio-button-group-element.ts
+++ b/projects/common/models/radio-button-group-element.ts
@@ -16,8 +16,8 @@ export class RadioButtonGroupElement extends InputElement implements FontElement
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initFontElement(serializedElement));
Object.assign(this, initSurfaceElement(serializedElement));
diff --git a/projects/common/models/text-area-element.ts b/projects/common/models/text-area-element.ts
index 60b2f7555..9db52d1cc 100644
--- a/projects/common/models/text-area-element.ts
+++ b/projects/common/models/text-area-element.ts
@@ -20,8 +20,8 @@ export class TextAreaElement extends InputElement implements FontElement, Surfac
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initFontElement(serializedElement));
Object.assign(this, initSurfaceElement(serializedElement));
diff --git a/projects/common/models/text-element.ts b/projects/common/models/text-element.ts
index aeedd7d04..78a1a2b52 100644
--- a/projects/common/models/text-element.ts
+++ b/projects/common/models/text-element.ts
@@ -14,8 +14,8 @@ export class TextElement extends UIElement implements SurfaceUIElement {
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initSurfaceElement(serializedElement));
this.fontColor = serializedElement.fontColor as string || 'black';
diff --git a/projects/common/models/text-field-element.ts b/projects/common/models/text-field-element.ts
index 459966ef9..a92ace4a3 100644
--- a/projects/common/models/text-field-element.ts
+++ b/projects/common/models/text-field-element.ts
@@ -26,8 +26,8 @@ export class TextFieldElement extends InputElement implements FontElement, Surfa
backgroundColor: string = 'transparent';
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initFontElement(serializedElement));
Object.assign(this, initSurfaceElement(serializedElement));
diff --git a/projects/common/models/uI-element.ts b/projects/common/models/uI-element.ts
index fa91dcf4e..e3456d20a 100644
--- a/projects/common/models/uI-element.ts
+++ b/projects/common/models/uI-element.ts
@@ -31,7 +31,7 @@ export abstract class UIElement {
marginTop: number = 0;
marginBottom: number = 0;
- protected constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
+ protected constructor(serializedElement: UIElement) {
Object.assign(this, serializedElement);
if (!serializedElement.id) {
this.id = IdService.getInstance().getNewID(serializedElement.type);
@@ -51,8 +51,8 @@ export abstract class InputElement extends UIElement {
required: boolean;
requiredWarnMessage: string;
- protected constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ protected constructor(serializedElement: UIElement) {
+ super(serializedElement);
this.label = serializedElement.label as string || 'Beispielbeschriftung';
this.value = serializedElement.value as string | number | boolean | null || null;
this.required = serializedElement.required as boolean || false;
diff --git a/projects/common/models/video-element.ts b/projects/common/models/video-element.ts
index 80a9ea4fe..a18de3976 100644
--- a/projects/common/models/video-element.ts
+++ b/projects/common/models/video-element.ts
@@ -23,8 +23,8 @@ export class VideoElement extends UIElement implements PlayerElement {
showRestTime: boolean = true;
playbackTime: number = 0;
- constructor(serializedElement: UIElement, coordinates?: { x: number; y: number }) {
- super(serializedElement, coordinates);
+ constructor(serializedElement: UIElement) {
+ super(serializedElement);
Object.assign(this, serializedElement);
Object.assign(this, initPlayerElement(serializedElement));
this.height = serializedElement.height || 230;
--
GitLab