From cabcae80882d612578a09f7cf3b3ae13190c6242 Mon Sep 17 00:00:00 2001
From: jojohoch <joachim.hoch@iqb.hu-berlin.de>
Date: Mon, 15 Nov 2021 10:19:50 +0100
Subject: [PATCH] [player] Show background color for dynamic sections
---
docs/release-notes-player.txt | 5 +++++
.../player/src/app/components/page/page.component.css | 6 ++++++
.../player/src/app/components/page/page.component.html | 10 +++-------
.../player/src/app/components/page/page.component.ts | 3 ++-
4 files changed, 16 insertions(+), 8 deletions(-)
create mode 100644 projects/player/src/app/components/page/page.component.css
diff --git a/docs/release-notes-player.txt b/docs/release-notes-player.txt
index d02f8c1dc..b9b160d16 100644
--- a/docs/release-notes-player.txt
+++ b/docs/release-notes-player.txt
@@ -1,5 +1,10 @@
Player
======
+1.5.0
+ - Show the magnifier only when the mouse is over the image
+ - Fix saving of inputs via the virtual keyboard
+ - Show background color for dynamic sections
+
1.4.1
- Make text underlinable
- Fix marking of text
diff --git a/projects/player/src/app/components/page/page.component.css b/projects/player/src/app/components/page/page.component.css
new file mode 100644
index 000000000..185623b18
--- /dev/null
+++ b/projects/player/src/app/components/page/page.component.css
@@ -0,0 +1,6 @@
+.section{
+ position: relative;
+ display: block;
+ overflow: auto;
+ width: 100%
+}
diff --git a/projects/player/src/app/components/page/page.component.html b/projects/player/src/app/components/page/page.component.html
index b0aa2233a..2ffe636f1 100644
--- a/projects/player/src/app/components/page/page.component.html
+++ b/projects/player/src/app/components/page/page.component.html
@@ -3,17 +3,13 @@
[intersectionContainer]="pagesContainer"
(intersecting)="onIntersection()">
<app-section *ngFor="let section of page.sections; let i = index"
+ class="section"
[pageIndex] = parentArrayIndex
[parentForm]="pageForm"
[parentArrayIndex]="i"
[section]="section"
- [ngStyle]="{
- position: 'relative',
- display: section.dynamicPositioning ? 'contents' : 'block',
- overflow: 'auto',
- width: '100%',
- 'background-color': section.backgroundColor,
- 'min-height': section.dynamicPositioning ? 'auto' : section.height + 'px'}">
+ [style.backgroundColor]="section.backgroundColor"
+ [style.minHeight]=" section.dynamicPositioning ? 'auto' : section.height + 'px'">
</app-section>
</div>
<div appIntersectionDetection
diff --git a/projects/player/src/app/components/page/page.component.ts b/projects/player/src/app/components/page/page.component.ts
index 9d2ebb1e1..340bfe6e6 100644
--- a/projects/player/src/app/components/page/page.component.ts
+++ b/projects/player/src/app/components/page/page.component.ts
@@ -8,7 +8,8 @@ import { Page } from '../../../../../common/models/page';
@Component({
selector: 'app-page',
- templateUrl: './page.component.html'
+ templateUrl: './page.component.html',
+ styleUrls: ['./page.component.css']
})
export class PageComponent implements OnInit {
--
GitLab