From f88d27bf2f6f788930a7cd7d47ef6988d19c17be Mon Sep 17 00:00:00 2001
From: rhenck <richard.henck@iqb.hu-berlin.de>
Date: Tue, 25 Jun 2024 15:06:50 +0200
Subject: [PATCH] Checkbox: Fix value initialization
The default value overwrites the value set in the parent constructor
(Javascript...). Therefore the value needs to be intialized explicitly
after the parent constructor has run.
---
.../common/components/input-elements/checkbox.component.ts | 2 +-
projects/common/models/elements/input-elements/checkbox.ts | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/projects/common/components/input-elements/checkbox.component.ts b/projects/common/components/input-elements/checkbox.component.ts
index 1ac235c9c..255c5835b 100644
--- a/projects/common/components/input-elements/checkbox.component.ts
+++ b/projects/common/components/input-elements/checkbox.component.ts
@@ -64,5 +64,5 @@ import { FormElementComponent } from '../../directives/form-element-component.di
})
export class CheckboxComponent extends FormElementComponent implements OnInit {
@Input() elementModel!: CheckboxElement;
- tableMode: boolean = true;
+ tableMode: boolean = false;
}
diff --git a/projects/common/models/elements/input-elements/checkbox.ts b/projects/common/models/elements/input-elements/checkbox.ts
index 2d602d4d7..db6205c71 100644
--- a/projects/common/models/elements/input-elements/checkbox.ts
+++ b/projects/common/models/elements/input-elements/checkbox.ts
@@ -23,12 +23,14 @@ export class CheckboxElement extends InputElement implements CheckboxProperties
constructor(element?: CheckboxProperties) {
super(element);
if (element && isValid(element)) {
+ this.value = element.value;
this.crossOutChecked = element.crossOutChecked;
this.styling = { ...element.styling };
} else {
if (environment.strictInstantiation) {
throw new InstantiationEror('Error at Checkbox instantiation', element);
}
+ if (element?.value !== undefined) this.value = element.value;
if (element?.crossOutChecked !== undefined) this.crossOutChecked = element.crossOutChecked;
this.dimensions = PropertyGroupGenerators.generateDimensionProps({
width: 215,
@@ -69,6 +71,7 @@ export class CheckboxElement extends InputElement implements CheckboxProperties
}
export interface CheckboxProperties extends InputElementProperties {
+ value: boolean;
crossOutChecked: boolean;
styling: BasicStyles;
}
--
GitLab