Skip to content
Snippets Groups Projects
Commit 14c3a09a authored by jojohoch's avatar jojohoch
Browse files

[player] Fix `ExpressionChangedAfterItHasBeenCheckedError`

* Remove workaround with `Promise.resolve().then(() => ...`
* Use `changeDetectorRef.detectChanges()` after updating the validators
parent cb4c7427
No related branches found
No related tags found
No related merge requests found
......@@ -42,6 +42,6 @@ export class FormService {
}
setValidators(validations: FormControlValidators): void {
Promise.resolve().then(() => this._validatorsAdded.next(validations));
this._validatorsAdded.next(validations);
}
}
import {
Component, Input, OnDestroy, OnInit
ChangeDetectorRef, Component, Input, OnDestroy, OnInit
} from '@angular/core';
import { FormArray, FormBuilder, FormGroup } from '@angular/forms';
import { Subject } from 'rxjs';
......@@ -39,7 +39,8 @@ export class FormComponent implements OnInit, OnDestroy {
private veronaSubscriptionService: VeronaSubscriptionService,
private veronaPostService: VeronaPostService,
private messageService: MessageService,
private translateService: TranslateService) {
private translateService: TranslateService,
protected changeDetectorRef: ChangeDetectorRef) {
}
ngOnInit(): void {
......@@ -77,6 +78,7 @@ export class FormComponent implements OnInit, OnDestroy {
private setValidators = (validators: FormControlValidators): void => {
validators.formGroup.controls[validators.id].setValidators(validators.validators);
validators.formGroup.controls[validators.id].updateValueAndValidity();
this.changeDetectorRef.detectChanges();
};
private onNavigationDenied(message: VopNavigationDeniedNotification): void {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment