[editor] Fix element alignment

- Move the method to the unit service, so the proper 
updateElementProperty method can be used.
- Also improve the logic, reducing variables.

projects/common/models/section.ts

@@ -47,35 +47,4 @@ export class Section {
       element.positionProps.dynamicPositioning = value;
     });
   }
-
-  static alignElements(elements: PositionedElement[], alignmentDirection: 'left' | 'right' | 'top' | 'bottom'): void {
-    let newValue: number;
-    switch (alignmentDirection) {
-      case 'left':
-        newValue = Math.min(...elements.map(element => element.positionProps.xPosition));
-        elements.forEach((element: UIElement) => {
-          element.xPosition = newValue;
-        });
-        break;
-      case 'right':
-        newValue = Math.max(...elements.map(element => element.positionProps.xPosition + element.width));
-        elements.forEach((element: UIElement) => {
-          element.xPosition = newValue - element.width;
-        });
-        break;
-      case 'top':
-        newValue = Math.min(...elements.map(element => element.positionProps.yPosition));
-        elements.forEach((element: UIElement) => {
-          element.yPosition = newValue;
-        });
-        break;
-      case 'bottom':
-        newValue = Math.max(...elements.map(element => element.positionProps.yPosition + element.height));
-        elements.forEach((element: UIElement) => {
-          element.yPosition = newValue - element.height;
-        });
-        break;
-      // no default
-    }
-  }
 }

projects/editor/src/app/components/unit-view/page-view/properties-panel/element-sizing-properties.component.ts

@@ -200,6 +200,6 @@ export class ElementSizingPropertiesComponent {
   constructor(private unitService: UnitService, public selectionService: SelectionService) { }
 
   alignElements(direction: 'left' | 'right' | 'top' | 'bottom'): void {
-    this.unitService.alignElements(this.selectionService.getSelectedElements(), direction);
+    this.unitService.alignElements(this.selectionService.getSelectedElements() as PositionedElement[], direction);
   }
 }

projects/editor/src/app/services/unit.service.ts

@@ -354,8 +354,38 @@ export class UnitService {
     );
   }
 
-  alignElements(elements: UIElement[], alignmentDirection: 'left' | 'right' | 'top' | 'bottom'): void {
-    Section.alignElements(elements as PositionedElement[], alignmentDirection);
+  alignElements(elements: PositionedElement[], alignmentDirection: 'left' | 'right' | 'top' | 'bottom'): void {
+    switch (alignmentDirection) {
+      case 'left':
+        this.updateElementProperty(
+          elements,
+          'xPosition',
+          Math.min(...elements.map(element => element.positionProps.xPosition))
+        );
+        break;
+      case 'right':
+        this.updateElementProperty(
+          elements,
+          'xPosition',
+          Math.max(...elements.map(element => element.positionProps.xPosition))
+        );
+        break;
+      case 'top':
+        this.updateElementProperty(
+          elements,
+          'yPosition',
+          Math.min(...elements.map(element => element.positionProps.yPosition))
+        );
+        break;
+      case 'bottom':
+        this.updateElementProperty(
+          elements,
+          'yPosition',
+          Math.max(...elements.map(element => element.positionProps.yPosition))
+        );
+        break;
+      // no default
+    }
     this.elementPropertyUpdated.next();
     this.veronaApiService.sendVoeDefinitionChangedNotification();
   }