Skip to content
Snippets Groups Projects
Commit 576e3e21 authored by rhenck's avatar rhenck
Browse files

[editor] Fix IDService tests to work with changed mehtod visibility

All created IDs are now always registered as well.
parent d4bb9e18
No related branches found
No related tags found
No related merge requests found
......@@ -88,7 +88,7 @@ export class SanitizationService {
if (!idManager.isIdAvailable(element.id)) {
console.warn(`Id already in: ${element.id}! Generating a new one...`);
this.repairLog.push(element.id);
element.id = idManager.getNewID((element as UIElement).type || 'value');
element.id = idManager.getAndRegisterNewID((element as UIElement).type || 'value');
}
idManager.addID(element.id);
......
......@@ -16,22 +16,22 @@ describe('IDService', () => {
idService.reset();
});
it('getNewID should fail on empty string param', () => {
expect(() => { idService.getNewID(''); }).toThrow(Error('ID-Service: No type given!'));
it('getAndRegisterNewID should fail on empty string param', () => {
expect(() => { idService.getAndRegisterNewID(''); }).toThrow(Error('ID-Service: No type given!'));
});
it('getNewID should return first ID', () => {
expect(idService.getNewID('text')).toBe('text_1');
it('getAndRegisterNewID should return first ID', () => {
expect(idService.getAndRegisterNewID('text')).toBe('text_1');
});
it('getNewID should return different IDs - counting up', () => {
idService.getNewID('text');
expect(idService.getNewID('text')).toBe('text_2');
it('getAndRegisterNewID should return different IDs - counting up', () => {
idService.getAndRegisterNewID('text');
expect(idService.getAndRegisterNewID('text')).toBe('text_2');
});
it('idService should return next id when one is already taken', () => {
idService.addID('text_1');
expect(idService.getNewID('text')).toBe('text_2');
expect(idService.getAndRegisterNewID('text')).toBe('text_2');
});
it('isIdAvailable should return false when id is already taken', () => {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment