This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git.
Pull mirroring updated .
- May 09, 2022
- May 05, 2022
-
-
rhenck authored
Makes more sense logically to pass the cloze element as a whole instead of just the document. Knowing about the document is the responsibility of the method not the caller.
-
- May 02, 2022
-
-
rhenck authored
-
rhenck authored
- Split text field and drop list, so they can have differing props - Improve their dimension default values - Improve alignment of all cloze children components - Add dynamic width parameter of toggle buttons to dimension properties panel. Therefore the postion tab can always be shown and no longer needs a condition.
-
- Apr 28, 2022
-
-
jojohoch authored
-
- Apr 25, 2022
-
-
rhenck authored
-
- Apr 22, 2022
- Apr 13, 2022
-
-
rhenck authored
-
- Mar 04, 2022
-
-
rhenck authored
The unit definition now has 2 meta-fields: 'type' and 'version'. The former has the fixed value of 'aspect-unit-definition'. The latters contains the version without any prefixes, i.e. '1.2.3'. The sanatizer tries to read the versions of older formats as well and uses the found version. This is important since the handlePlusOne method must only run of a specific version (in the old format). The sanatizer no longer shows any messages and therefore does not need the MessageService anymore. The information about whether sanatization happened or not is returned as second parameter for those that are interested. The editor is, the player is not. The editor API service now constructs the 'unitDefinitionType' parameter from both values, resulting in something like 'aspect-unit-definition@1.2.3'.
-
- Mar 02, 2022
-
-
rhenck authored
- Units and element are now built via the factory. This ensures only the wanted properties are present. All others are discarded. - Since the sanatizer is supposed to check the unit defintion version it is used by player and editor and therefore put in common. This in turn makes it necessary to put the JSON resolver settings in the root-TSConfig file. - Renamed a couple of properties to have clearer names.
-
- Nov 26, 2021
-
-
rhenck authored
The problem being solved is that compound-sub-elements must not have all the properties other elements have. For exampe positioning info. Sub-Elements are positioned inline. To avoid having similar class inheritance structures for positioned and inline elements, we use interface. Positioning is done via interface and is therefore optional. Those optional properties are kept in an object in a variable. This allows to hide specifics from element classes and removes the need to initialize all the fields in every class using the interface. The elements mostly care about their own specific properties anyway. The same technique is used for font and surface elements. Here we also don't want to initialize all the styles in every class. Changing values of element properties works like before. Just set the property as if it would be a direkt prop of the element. The element itself puts the value in the currect sub-object (positioningProps, fontProps etc). For reading the values there is a similar method, but it is not used anywhere by now. Since the properties panel operates on the raw values anyway (refer CombinedProperties) and for element components this would mean calling a function in the template, which caused change detection to run the function very often and is therefore bad practice. Additional notes and refactorings: - Restructure all files in common. UIElements in the same folder etc. - Move all interfaces to the UIElement file. This avoids circular imports, which would be needed to allow PositionedElement to extend UIElement. - Interface initializers also handle reading values in the old form. - Add PositionedElement for use in canvas overlays. This is a UIElement with guaranteed postionProps. - Don't export all Material packages from common, only the ones used in player and editor. The rest is only used in common and does not need to be exported.
-