Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Mar 15, 2022
  2. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  3. Mar 01, 2022
  4. Feb 28, 2022
  5. Feb 18, 2022
  6. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  7. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  8. Jan 28, 2022
  9. Jan 04, 2022
    • jojohoch's avatar
      [player] Fix disappearance of scrollable page content · 50298f71
      jojohoch authored
      When a page has longer scrollable dynamic content that consists of many
      individual elements (Likert), the content was sometimes not displayed
      after interacting with those elements. This happened in the maximized
      browser display, especially in Firefox.
      Probably due to the deep dynamic nesting the height to be displayed
      could not be calculated correctly
      50298f71
  10. Dec 15, 2021
  11. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  12. Nov 24, 2021
  13. Nov 08, 2021
  14. Oct 29, 2021
  15. Oct 28, 2021
    • jojohoch's avatar
      Refactor form-element-component.directive.ts · 6c38e1c0
      jojohoch authored
      * Remove FormService Injection
      * Move FormService and form types to player
      * Move interface ValueChangeElement to uI-element.ts
      * Use interface InputElementValue instead of
      string | number | boolean | null
      6c38e1c0
  16. Oct 18, 2021
  17. Oct 15, 2021
  18. Oct 14, 2021
  19. Oct 06, 2021
    • jojohoch's avatar
      [player] Refactor `UnitStateService` · 351bec38
      jojohoch authored
      * Take over tasks of `UnitStateComponent`
      * Manage property `unitStateElementCode`
      * Removing the passing of the property `unitStateElementCode` by
      the components
      351bec38
  20. Oct 04, 2021
    • jojohoch's avatar
      [player] Change storage format · 6a4bbeaa
      jojohoch authored
      * `UnitState.dataparts` has property `elementCodes` property, which
      stores status, value and id for FormElement
      * When building a unit, the stored value is assigned to the element
      when it is initiated
      * Removed `UnitState.dataparts.pages`
      * Removed methods initPages and addStoredValues
      6a4bbeaa
  21. Oct 01, 2021
  22. Sep 25, 2021
  23. Sep 24, 2021
  24. Sep 23, 2021
  25. Sep 22, 2021
  26. Sep 20, 2021
  27. Sep 01, 2021
  28. Aug 31, 2021
  29. Aug 20, 2021
  30. Aug 18, 2021
  31. Aug 17, 2021
Loading