Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Nov 29, 2021
  2. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  3. Nov 24, 2021
    • rhenck's avatar
      Improve styling of cloze sub-elements · 447fa70b
      rhenck authored
      The issue here is the alignment if dropLists and text fields. They are 
      supposed to be exactly in line with the text which is very complicated 
      with Material components, which are heavily nested and contain several 
      sub-elements which need to be changed - removing margins, paddings and 
      other position related styles.
      447fa70b
  4. Nov 22, 2021
  5. Nov 19, 2021
  6. Nov 15, 2021
  7. Nov 10, 2021
    • rhenck's avatar
      Refactor elements to use the model's value · 373108a5
      rhenck authored
      This change mainly helps the editor.
      The idea is to make the element components have the correct value of
      their model and don't rely on the formcontrol value. The formcontrol
      can be hard to manipulate, especially in compound elements. Setting
      the model value is way easier.
      
      The formcontrols are kept and should not interfere.
      373108a5
  8. Oct 29, 2021
  9. Oct 28, 2021
  10. Oct 18, 2021
  11. Oct 15, 2021
  12. Oct 13, 2021
    • rhenck's avatar
      Add classes for all models · 0473666d
      rhenck authored
      - Remove interfaces
      - Add classes for all elements as well as unit, page and section
      - 2 intermediate interfaces are kept. They dont constituate a viable 
      object but only additional properties, like background-color. Those can 
      be added as interface to all elements. Initialisation has to be done by 
      the element itself though and not by some constructor higher up.
      0473666d
  13. Oct 07, 2021
  14. Sep 30, 2021
    • jojohoch's avatar
      [player] Refactor validation messages · 4005b51e
      jojohoch authored
      * Delete validation message component
      * Use instead `mat-error` inside element components to take advantage
       of `mat-input-field`
      * Add get validators method to each form element component
      * Display validation messages via `error-transform` pipe
      4005b51e
  15. Sep 29, 2021
    • rhenck's avatar
      Fix background color of input fields · c1d22c87
      rhenck authored
      Since the material elements don't give a way of applying the background 
      color, a hack is needed to get the internal elements and apply the 
      style.
      
      Directive to be able to do it for text field and text area.
      c1d22c87
  16. Sep 22, 2021
  17. Sep 21, 2021
  18. Aug 16, 2021
  19. Aug 03, 2021
    • rhenck's avatar
      Set all elements width and heigth to 100% · 9e3c0613
      rhenck authored
      This is in preparation for dynamic layouting.
      The actual dimensions are set by the overlay component which differs but 
      is existent for both editor and player.
      9e3c0613
  20. Jul 28, 2021
  21. Jul 23, 2021
  22. Jul 20, 2021
  23. Jul 16, 2021
    • jojohoch's avatar
      [player] Prepare validation of form elements · 89c6ebdf
      jojohoch authored
      * When creating components for each element a
      `ValidationMessageComponent` is also generated dynamically
      * Prepare usage of default values for form elements
      * Add `form.ts` for form specific interfaces
      * Rename some variables and properties
      89c6ebdf
  24. Jul 15, 2021
  25. Jul 13, 2021
    • jojohoch's avatar
      9b581084
    • rhenck's avatar
      Refactor unit model · eabe82c2
      rhenck authored
      The UIComponents now only have the properties they can make use of. This 
      means that the angular components use the CSS properties explicitly 
      instead of having all kinds of useless CSS properties.
      Also it is no longer needed to update the CSS styles via event because 
      Angular's change detection takes care of that.
      eabe82c2
  26. Jul 12, 2021
  27. Jul 09, 2021
    • jojohoch's avatar
      [player] Add form tag to player · 8d757e4c
      jojohoch authored
      * Introduce `FormService` to provide communication between
      element components and form
      * Add `ngModelChange` and `formControl` to
      some element components. This functionality is not used by
      the editor
      8d757e4c
  28. Jun 29, 2021
  29. Jun 28, 2021
Loading