Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Sep 12, 2023
    • rhenck's avatar
      Fix text-field element background color · e27b230b
      rhenck authored
      The CSS selector for what the element to color changed (most likely with 
      the Angular Material update). Also a lower z-index is needed to not 
      cover the text.
      
      #534
      e27b230b
  2. Jun 05, 2023
  3. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  4. Dec 10, 2021
  5. Dec 09, 2021
    • rhenck's avatar
      Remove text field and area appearance variants and fix remaining · 7a3c8be2
      rhenck authored
      The other  variants are basically the same as filled. The only
      difference is the background color, which we are manilupating anyway.
      So there is no reason to keep them.
      
      Also for the background color directive different target elements are
      needed for the different appearance variants. This is now possible.
      As stylings of the old appearance are kept when changing the appearance
      the styles need to be removed first.
      In the moment the appearance value is changed the component is not
      actually changed yet and there we need to wait for another Angular
      change detection cycle, via timeout.
      7a3c8be2
  6. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  7. Oct 04, 2021
  8. Sep 29, 2021
    • rhenck's avatar
      Fix background color of input fields · c1d22c87
      rhenck authored
      Since the material elements don't give a way of applying the background 
      color, a hack is needed to get the internal elements and apply the 
      style.
      
      Directive to be able to do it for text field and text area.
      c1d22c87
Loading