Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Dec 20, 2021
  2. Dec 15, 2021
  3. Dec 13, 2021
  4. Dec 10, 2021
  5. Dec 08, 2021
  6. Nov 29, 2021
  7. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  8. Nov 22, 2021
  9. Nov 19, 2021
  10. Nov 17, 2021
  11. Nov 15, 2021
  12. Nov 11, 2021
  13. Nov 10, 2021
  14. Nov 09, 2021
  15. Nov 08, 2021
  16. Nov 03, 2021
  17. Nov 01, 2021
  18. Oct 29, 2021
  19. Oct 28, 2021
    • jojohoch's avatar
      Refactor form-element-component.directive.ts · 6c38e1c0
      jojohoch authored
      * Remove FormService Injection
      * Move FormService and form types to player
      * Move interface ValueChangeElement to uI-element.ts
      * Use interface InputElementValue instead of
      string | number | boolean | null
      6c38e1c0
  20. Oct 27, 2021
  21. Oct 26, 2021
  22. Oct 22, 2021
  23. Oct 19, 2021
  24. Oct 18, 2021
Loading