This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git.
Pull mirroring updated .
- Jan 22, 2022
- Jan 21, 2022
- Jan 20, 2022
-
-
rhenck authored
Only the overlay can be clicked. This way the statre of the elements can not be changed which might be confused for actual value changes. Those can still only be done via properties panel. Unfortunately we need another variable so the cloze elements knows when it runs in the editor or not.
-
- Jan 19, 2022
-
-
rhenck authored
Compound elements are now supposed to use overlays for their child elements. This overlay makes selecting child components (by clicking on them) and marking them as selected (done by the selection service) possible. The SelectionService no longer needs special logic to handle compound children selection, as they now also have an overlay with the same interface as normal (canvas) elements. A few modifications in connected directives are necessary. The now handle children components in a proper array instead of QueryList. Likert elements do not have clickable children yet and work a little differently. This should probably be unitized in the future.
-
- Jan 18, 2022
-
-
jojohoch authored
Do not consider all form elements, but use a list containing only form elements with validators
-
- Jan 10, 2022
-
-
jojohoch authored
-
- Dec 10, 2021
-
-
rhenck authored
Variable naming, reorder imports etc.
-
- Dec 09, 2021
-
-
rhenck authored
The other variants are basically the same as filled. The only difference is the background color, which we are manilupating anyway. So there is no reason to keep them. Also for the background color directive different target elements are needed for the different appearance variants. This is now possible. As stylings of the old appearance are kept when changing the appearance the styles need to be removed first. In the moment the appearance value is changed the component is not actually changed yet and there we need to wait for another Angular change detection cycle, via timeout.
-
- Nov 26, 2021
-
-
rhenck authored
The problem being solved is that compound-sub-elements must not have all the properties other elements have. For exampe positioning info. Sub-Elements are positioned inline. To avoid having similar class inheritance structures for positioned and inline elements, we use interface. Positioning is done via interface and is therefore optional. Those optional properties are kept in an object in a variable. This allows to hide specifics from element classes and removes the need to initialize all the fields in every class using the interface. The elements mostly care about their own specific properties anyway. The same technique is used for font and surface elements. Here we also don't want to initialize all the styles in every class. Changing values of element properties works like before. Just set the property as if it would be a direkt prop of the element. The element itself puts the value in the currect sub-object (positioningProps, fontProps etc). For reading the values there is a similar method, but it is not used anywhere by now. Since the properties panel operates on the raw values anyway (refer CombinedProperties) and for element components this would mean calling a function in the template, which caused change detection to run the function very often and is therefore bad practice. Additional notes and refactorings: - Restructure all files in common. UIElements in the same folder etc. - Move all interfaces to the UIElement file. This avoids circular imports, which would be needed to allow PositionedElement to extend UIElement. - Interface initializers also handle reading values in the old form. - Add PositionedElement for use in canvas overlays. This is a UIElement with guaranteed postionProps. - Don't export all Material packages from common, only the ones used in player and editor. The rest is only used in common and does not need to be exported.
-