Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Feb 02, 2024
  2. Nov 13, 2023
  3. Jun 15, 2023
  4. Jun 13, 2023
  5. Jun 05, 2023
  6. May 05, 2023
  7. Oct 18, 2022
  8. Aug 09, 2022
  9. Aug 08, 2022
  10. Aug 02, 2022
  11. May 17, 2022
    • rhenck's avatar
      Refactor model interfaces to classes · 2e9be6e9
      rhenck authored
      This way elements can handle their logic themselves without having to
      rely on outside utility classes.
      
      Also restructure files in common in a more logical way.
      2e9be6e9
  12. Apr 22, 2022
  13. Apr 14, 2022
  14. Apr 07, 2022
  15. Apr 06, 2022
  16. Apr 04, 2022
    • rhenck's avatar
      Clean likert interfaces · 07921403
      rhenck authored
      The LikertColumn is actually just an image-text-combo. Has a generalized 
      name now.
      The other interface was not needed anymore and has been deleted.
      07921403
  17. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  18. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  19. Jan 20, 2022
    • rhenck's avatar
      Use index + 1 for element list values · 5bcf68f0
      rhenck authored
      All elements which report the selected index are supposed to send an 
      index starting with 1 instead of 0. This a special requirement for the 
      analysis of answers.
      5bcf68f0
  20. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  21. Nov 11, 2021
    • rhenck's avatar
      [editor] Refactor directory structure and separate dialog components · cc549202
      rhenck authored
      This structure moves closer to the structure template the team decided
      on. Components and services are kept in dedicated folders instead of
      following the logical code structure. This is still not the case here as
      the unit-view component is still nested, but it's closer.
      cc549202
Loading