Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Jan 20, 2022
  2. Jan 19, 2022
    • rhenck's avatar
      Rework compound child components · 87effdf7
      rhenck authored
      Compound elements are now supposed to use overlays for their child
      elements. This overlay makes selecting child components (by clicking on
      them) and marking them as selected (done by the selection service)
      possible.
      The SelectionService no longer needs special logic to handle compound
      children selection, as they now also have an overlay with the same
      interface as normal (canvas) elements.
      
      A few modifications in connected directives are necessary. The now
      handle children components in a proper array instead of QueryList.
      
      Likert elements do not have clickable children yet and work a little
      differently. This should probably be unitized in the future.
      87effdf7
  3. Jan 17, 2022
  4. Jan 12, 2022
    • rhenck's avatar
      Rework cloze element data · 15cdca5e
      rhenck authored
      - Now only has a variable 'document'. This holds the HTML representation
        in an object. This object is enriched with element models.
      - Because the the TextEditor extension can neither create multiple
        element instances nor use the IDService to generate their IDs, this
        has to be done afterwards. See ClozeParser.
      - The cloze element has rather extensive compatibility handling because
        cloze elements used to save an actual HTML representation. This has to
        be transformed to JSON/object. Therefore we replace the old backslash-
        markers with custom HTML tags. The editor object does this
        transformation. It needs some custom extensions to recognize (and
        don't remove) the HTML tags though.
      - Cloze now shows a placeholder text when empty
      - The cloze component needs a small pipe to extract text formatting
        options from the paragraph parts.
      - For getting the child elements for the player the models have to be
        extracted from the somewhat complex (JSON)document.
      - Added some rudimentary interfaces for the TextEditor document format.
      - Removed the old ClozePart interface. This is quasi part of the new
        interfaces.
      15cdca5e
  5. Dec 16, 2021
    • rhenck's avatar
      Add fixedSize styling to most elements · 27b284c7
      rhenck authored
      Elements are supposed to be centred when this setting is used. Since it 
      is the same CSS for almost all element components it is put into global 
      styles.
      
      Missing components: video, spelling.
      27b284c7
  6. Dec 10, 2021
    • rhenck's avatar
      Move ID-Service to editor · 03e8c00b
      rhenck authored
      Generally only the editor needs to generate new IDs. Before there was
      need to have it in common because some elements (like compound elements)
      needed to generte new Elements including IDs.
      Now all ID stuff is handled by the UnitService and the elements classes
      are handed the fully built elements. Unfortunately this means that some
      logic has to move back from classes into the UnitService. To un-bloat
      the UnitService a (and in the future some more) helper class is created
      for this logic.
      
      The most important thing is, that the UIElement no longer generates
      an ID when created. The ID has to be created before and passed to the
      constructor.
      03e8c00b
  7. Dec 07, 2021
  8. Dec 01, 2021
  9. Nov 29, 2021
  10. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  11. Nov 25, 2021
    • rhenck's avatar
      Add new element TextFieldSimple · 751a65fe
      rhenck authored
      This is a native input element which is used in cloze elements. Here 
      (sub)elements need to be positioned inline, which is hard to do with 
      material components.
      
      Also add a method to all form elements to set their form value, which is 
      now only used by the simple text field but may be useful for other 
      elements, which don't integrate in material form fields.
      751a65fe
  12. Nov 24, 2021
    • rhenck's avatar
      Improve styling of cloze sub-elements · 447fa70b
      rhenck authored
      The issue here is the alignment if dropLists and text fields. They are 
      supposed to be exactly in line with the text which is very complicated 
      with Material components, which are heavily nested and contain several 
      sub-elements which need to be changed - removing margins, paddings and 
      other position related styles.
      447fa70b
  13. Nov 23, 2021
  14. Nov 22, 2021
  15. Nov 20, 2021
  16. Nov 19, 2021
    • rhenck's avatar
      Add specific styling for Cloze children components · 43676782
      rhenck authored
      Child elements need some special CSS, for example to prevent taking up 
      more space than needed.
      This is only for text field and drop list, which are the relevant sub 
      elements for now.
      43676782
    • rhenck's avatar
      24d0152e
    • rhenck's avatar
      Refactor Cloze element to allow clicking on element in the player · 761d22bc
      rhenck authored
      A new variable is introduced for CompoundComponents: 
      "allowClickThrough". With this set components can set their children and 
      overlays to allow clicking on child elements or not. In the editor this 
      is not wanted as the elements internal structure is different and the 
      resulting event target can not be reliably styled. There we need the 
      (span) overlay.
      In the player though elements should be clickable as usual. The player 
      can completely ignore this setting as it is on true (allowing clicking) 
      by default.
      761d22bc
    • rhenck's avatar
      Add new element Cloze · b225a5ee
      rhenck authored
      Similar to a text element but parses the text on change an replaces 
      markers with actual elements.
      The text is then displayed inline with the elements.
      b225a5ee
Loading