Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. May 31, 2022
  2. May 25, 2022
  3. May 18, 2022
  4. May 17, 2022
    • rhenck's avatar
      Refactor model interfaces to classes · 2e9be6e9
      rhenck authored
      This way elements can handle their logic themselves without having to
      rely on outside utility classes.
      
      Also restructure files in common in a more logical way.
      2e9be6e9
  5. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  6. Feb 08, 2022
  7. Jan 25, 2022
  8. Jan 24, 2022
  9. Jan 22, 2022
  10. Jan 18, 2022
  11. Jan 17, 2022
    • rhenck's avatar
      Extend cloze element · 5f69cce6
      rhenck authored
      Is now able to interpret more stuff from the editor. The only thing 
      missing are the list styles.
      5f69cce6
  12. Jan 13, 2022
  13. Jan 12, 2022
    • rhenck's avatar
      Make InputElement labe optional and remove it from cloze children · 5b90fa99
      rhenck authored
      Cloze elements are displayed inline and have no way to show a label.
      5b90fa99
    • rhenck's avatar
      Rework cloze element data · 15cdca5e
      rhenck authored
      - Now only has a variable 'document'. This holds the HTML representation
        in an object. This object is enriched with element models.
      - Because the the TextEditor extension can neither create multiple
        element instances nor use the IDService to generate their IDs, this
        has to be done afterwards. See ClozeParser.
      - The cloze element has rather extensive compatibility handling because
        cloze elements used to save an actual HTML representation. This has to
        be transformed to JSON/object. Therefore we replace the old backslash-
        markers with custom HTML tags. The editor object does this
        transformation. It needs some custom extensions to recognize (and
        don't remove) the HTML tags though.
      - Cloze now shows a placeholder text when empty
      - The cloze component needs a small pipe to extract text formatting
        options from the paragraph parts.
      - For getting the child elements for the player the models have to be
        extracted from the somewhat complex (JSON)document.
      - Added some rudimentary interfaces for the TextEditor document format.
      - Removed the old ClozePart interface. This is quasi part of the new
        interfaces.
      15cdca5e
  14. Jan 10, 2022
    • rhenck's avatar
      Refactor unit definition versioning · 29a1b359
      rhenck authored
      - Improve variable naming for unit definiton type. (version string)
      - Use 'iqb-aspect-definition@1.0.0' as value which better communicates
        the purpose of the data.
      - Also update the HTML files with the new definition. (Even though it is
        not checked anywhere.)
      29a1b359
  15. Jan 07, 2022
  16. Dec 17, 2021
    • rhenck's avatar
      [editor] Fix element alignment · 5269a5f4
      rhenck authored
      - Move the method to the unit service, so the proper 
      updateElementProperty method can be used.
      - Also improve the logic, reducing variables.
      5269a5f4
  17. Dec 15, 2021
    • rhenck's avatar
      Add new position property 'fixedSize' · 47b96d9b
      rhenck authored
      This allows elements in dynamic sections to have fixed dimensions.
      
      Some modifications to property panel logic, to show dimension fields and
      proper labels.
      
      Only implmented in dropList and button elements.
      47b96d9b
  18. Dec 10, 2021
    • rhenck's avatar
      Improve code style · ce392fca
      rhenck authored
      Variable naming, reorder imports etc.
      ce392fca
    • rhenck's avatar
      Refactor ElementFactory to abstract class · 33e72a0b
      rhenck authored
      This makes for cleaner imports.
      33e72a0b
    • rhenck's avatar
      [editor] Fix element duplication · 2e743910
      rhenck authored
      Was not correctly creating new instances of non-primitive values. Now
      uses "JSON.parse(JSON.stringify(element))" for deep copying the element
      first.
      
      Also refactor by moving the method to the UnitService, where all ID
      handling should take place.
      2e743910
    • rhenck's avatar
      Move ID-Service to editor · 03e8c00b
      rhenck authored
      Generally only the editor needs to generate new IDs. Before there was
      need to have it in common because some elements (like compound elements)
      needed to generte new Elements including IDs.
      Now all ID stuff is handled by the UnitService and the elements classes
      are handed the fully built elements. Unfortunately this means that some
      logic has to move back from classes into the UnitService. To un-bloat
      the UnitService a (and in the future some more) helper class is created
      for this logic.
      
      The most important thing is, that the UIElement no longer generates
      an ID when created. The ID has to be created before and passed to the
      constructor.
      03e8c00b
  19. Dec 07, 2021
  20. Dec 02, 2021
    • rhenck's avatar
      Switch to Partials for serializedElements · 606c392f
      rhenck authored
      The given serialized properties may not conform to all UIElement 
      properties. They are merely meant as a building plan; they may also 
      contain outdated properties which have to be transformed when reading.
      606c392f
    • rhenck's avatar
      Add Frame element · 024709a6
      rhenck authored
      Basically a div with border properties as usual.
      024709a6
  21. Dec 01, 2021
  22. Nov 30, 2021
  23. Nov 26, 2021
    • jojohoch's avatar
      [player] Add option to disable muting of audios and videos · 4eb6dce0
      jojohoch authored
      The interaction can now be turned off without hiding the button.
      4eb6dce0
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  24. Nov 25, 2021
    • rhenck's avatar
      Add new element TextFieldSimple · 751a65fe
      rhenck authored
      This is a native input element which is used in cloze elements. Here 
      (sub)elements need to be positioned inline, which is hard to do with 
      material components.
      
      Also add a method to all form elements to set their form value, which is 
      now only used by the simple text field but may be useful for other 
      elements, which don't integrate in material form fields.
      751a65fe
  25. Nov 24, 2021
    • rhenck's avatar
      Improve styling of cloze sub-elements · 447fa70b
      rhenck authored
      The issue here is the alignment if dropLists and text fields. They are 
      supposed to be exactly in line with the text which is very complicated 
      with Material components, which are heavily nested and contain several 
      sub-elements which need to be changed - removing margins, paddings and 
      other position related styles.
      447fa70b
    • rhenck's avatar
      Add new general property useMinHeight · b44784b6
      rhenck authored
      Min-height should be optional for dynamically positioned elements, as 
      you usually don't need it and it causes more problems than it solves. 
      Elements with min-height have cause unexpected margins between elements.
      b44784b6
  26. Nov 23, 2021
Loading