Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Aug 01, 2022
  2. Jun 03, 2022
    • rhenck's avatar
      Fix type issues · e1ab36e3
      rhenck authored
      Remove 'any's be adding proper types and using 'never'.
      e1ab36e3
  3. Jun 01, 2022
    • rhenck's avatar
      Quick and dirty fix sanitization service tests · 2f9dcce3
      rhenck authored
      2f9dcce3
    • rhenck's avatar
      Fix simple drop list properties panel · f63443af
      rhenck authored
      Now properly finds all normal and simple drop lists.
      This is achieved by a new method of unit all it's sub-components, which 
      returns all contained elements with and optional type filter.
      
      Also improve (still not very pretty) styling of the drop list props 
      panel.
      
      #260 #259
      f63443af
    • rhenck's avatar
      Fix IDService unit tests · d458e13c
      rhenck authored
      The service is no longer an Angular service, but is now a basic 
      singleton.
      d458e13c
    • rhenck's avatar
      Add sanitization for drop-list-simple · e74d1ae5
      rhenck authored
      e74d1ae5
    • rhenck's avatar
      Fix sanitization of cloze elements · 044b0c92
      rhenck authored
      The creation of a temporary cloze elements fails when it encounters 
      unknown child types.
      Therefore we use a static ClozeElement method to get the child elements 
      from the document instead of the whole element.
      044b0c92
    • rhenck's avatar
      Rework class initialization · f28b0678
      rhenck authored
      - Elements initialize their fields explicitly and not with
        Object.assign, since Object.assign also assigns
        (and therefore overwrites) parent fields.
      - IDService is no longer an Angular service but a basic singleton. This
        allows to use it in classes.
      - The IDManager can be optionally passed to unit and element
        constructors. When present the elements check and fix their given ID
        when created.
        This way elements can be created without depending on the external
        IDManager but also with the dependency.
      - ElementFactory is no longer used to create elements. Those are now
        either created directly via 'new' or via the Section, which knows the
        different element types.
      f28b0678
  4. May 17, 2022
  5. May 10, 2022
  6. May 09, 2022
  7. May 05, 2022
  8. May 02, 2022
  9. Apr 28, 2022
  10. Apr 25, 2022
  11. Apr 22, 2022
  12. Apr 13, 2022
  13. Mar 04, 2022
    • rhenck's avatar
      Refactor unit definition version and sanatization · 2b58b89a
      rhenck authored
      The unit definition now has 2 meta-fields: 'type' and 'version'.
      The former has the fixed value of 'aspect-unit-definition'.
      The latters contains the version without any prefixes, i.e. '1.2.3'.
      
      The sanatizer tries to read the versions of older formats as well and
      uses the found version. This is important since the handlePlusOne
      method must only run of a specific version (in the old format).
      
      The sanatizer no longer shows any messages and therefore does not need
      the MessageService anymore. The information about whether sanatization
      happened or not is returned as second parameter for those that are
      interested. The editor is, the player is not.
      
      The editor API service now constructs the 'unitDefinitionType'
      parameter from both values, resulting in something like
      'aspect-unit-definition@1.2.3'.
      2b58b89a
  14. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  15. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
Loading