This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git.
Pull mirroring updated .
- Jun 03, 2022
-
-
rhenck authored
-
- Jun 02, 2022
-
-
jojohoch authored
- problem with nullish values
-
- Jun 01, 2022
-
-
rhenck authored
Now properly finds all normal and simple drop lists. This is achieved by a new method of unit all it's sub-components, which returns all contained elements with and optional type filter. Also improve (still not very pretty) styling of the drop list props panel. #260 #259
-
rhenck authored
- Elements initialize their fields explicitly and not with Object.assign, since Object.assign also assigns (and therefore overwrites) parent fields. - IDService is no longer an Angular service but a basic singleton. This allows to use it in classes. - The IDManager can be optionally passed to unit and element constructors. When present the elements check and fix their given ID when created. This way elements can be created without depending on the external IDManager but also with the dependency. - ElementFactory is no longer used to create elements. Those are now either created directly via 'new' or via the Section, which knows the different element types.
-
- May 18, 2022
-
-
rhenck authored
Elements read as classes were overwritten by the plain objects passed to the constructors.
-
- May 17, 2022
-
-
rhenck authored
This way elements can handle their logic themselves without having to rely on outside utility classes. Also restructure files in common in a more logical way.
-
- Feb 17, 2022
-
-
rhenck authored
This removes all the classes and goes back to simple interfaces for unit, pages etc and all elements. This makes creating them easier and cleaner. Things like specific needs when setting element properties and most importantly compatibility handling is done by a special service module, that knows all the elements and how to repair old their potentially outdated definitions.
-
- Dec 17, 2021
-
-
rhenck authored
- Move the method to the unit service, so the proper updateElementProperty method can be used. - Also improve the logic, reducing variables.
-
- Dec 10, 2021
-
-
rhenck authored
This makes for cleaner imports.
-
rhenck authored
Was not correctly creating new instances of non-primitive values. Now uses "JSON.parse(JSON.stringify(element))" for deep copying the element first. Also refactor by moving the method to the UnitService, where all ID handling should take place.
-
- Dec 02, 2021
-
-
rhenck authored
The given serialized properties may not conform to all UIElement properties. They are merely meant as a building plan; they may also contain outdated properties which have to be transformed when reading.
-
- Nov 26, 2021
-
-
rhenck authored
The problem being solved is that compound-sub-elements must not have all the properties other elements have. For exampe positioning info. Sub-Elements are positioned inline. To avoid having similar class inheritance structures for positioned and inline elements, we use interface. Positioning is done via interface and is therefore optional. Those optional properties are kept in an object in a variable. This allows to hide specifics from element classes and removes the need to initialize all the fields in every class using the interface. The elements mostly care about their own specific properties anyway. The same technique is used for font and surface elements. Here we also don't want to initialize all the styles in every class. Changing values of element properties works like before. Just set the property as if it would be a direkt prop of the element. The element itself puts the value in the currect sub-object (positioningProps, fontProps etc). For reading the values there is a similar method, but it is not used anywhere by now. Since the properties panel operates on the raw values anyway (refer CombinedProperties) and for element components this would mean calling a function in the template, which caused change detection to run the function very often and is therefore bad practice. Additional notes and refactorings: - Restructure all files in common. UIElements in the same folder etc. - Move all interfaces to the UIElement file. This avoids circular imports, which would be needed to allow PositionedElement to extend UIElement. - Interface initializers also handle reading values in the old form. - Add PositionedElement for use in canvas overlays. This is a UIElement with guaranteed postionProps. - Don't export all Material packages from common, only the ones used in player and editor. The rest is only used in common and does not need to be exported.
-
- Oct 25, 2021
-
-
rhenck authored
No longer is async. For elements which need upfront source info (media), the media prompf is done in the unit service. Here we can keep it simple. Also remove coordinates from factory as this is information that does not need to be known here. This is also handled in the unit service where applicable.
-
- Oct 18, 2021
-
-
rhenck authored
The new elements now correctly set their own dynamicPositioning parameter to the setting of it's parent section.
-
- Oct 15, 2021
- Oct 14, 2021
-
-
rhenck authored
When those switches are on the size values are ignored and calculated automatically instead.
-
- Oct 13, 2021
-
-
rhenck authored
- Remove interfaces - Add classes for all elements as well as unit, page and section - 2 intermediate interfaces are kept. They dont constituate a viable object but only additional properties, like background-color. Those can be added as interface to all elements. Initialisation has to be done by the element itself though and not by some constructor higher up.
-