Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Dec 13, 2021
  2. Dec 10, 2021
    • rhenck's avatar
      Refactor ElementFactory to abstract class · 33e72a0b
      rhenck authored
      This makes for cleaner imports.
      33e72a0b
    • rhenck's avatar
      [editor] Refactor canvas component events · 4a60c8c2
      rhenck authored
      The dropListList generation is now done when things are changed via the 
      section menu and no longer on element update via unit service.
      Also remove some interfaces to avoid circular imports. The interfaces 
      are so small and insignificant that their form might as well be 
      specified at usage point.
      4a60c8c2
    • rhenck's avatar
      [editor] Refactor unit service · 53f4e848
      rhenck authored
      No longer have unit as subject. Components can use the unit variable as 
      is and still get updated.
      This removes some listener stuff in conected components.
      53f4e848
    • rhenck's avatar
      [editor] Fix element duplication · 2e743910
      rhenck authored
      Was not correctly creating new instances of non-primitive values. Now
      uses "JSON.parse(JSON.stringify(element))" for deep copying the element
      first.
      
      Also refactor by moving the method to the UnitService, where all ID
      handling should take place.
      2e743910
    • rhenck's avatar
      Refactor IDService and add unit tests · 7affe7f9
      rhenck authored
      No longer is a singleton but a normal servicce now again. The singleton 
      logic was needed in the past but not anymore.
      7affe7f9
    • rhenck's avatar
      Move FileService to editor · bfd5272c
      rhenck authored
      bfd5272c
  3. Dec 09, 2021
    • rhenck's avatar
      Add coloring options to taoggle-button · 0b8056f0
      rhenck authored
      Now correctly sets the chosen background color and additionally sets 
      another (configurable) color to the selected value.
      0b8056f0
    • rhenck's avatar
      Remove text field and area appearance variants and fix remaining · 7a3c8be2
      rhenck authored
      The other  variants are basically the same as filled. The only
      difference is the background color, which we are manilupating anyway.
      So there is no reason to keep them.
      
      Also for the background color directive different target elements are
      needed for the different appearance variants. This is now possible.
      As stylings of the old appearance are kept when changing the appearance
      the styles need to be removed first.
      In the moment the appearance value is changed the component is not
      actually changed yet and there we need to wait for another Angular
      change detection cycle, via timeout.
      7a3c8be2
  4. Dec 08, 2021
  5. Dec 07, 2021
    • rhenck's avatar
      Improve code style · 9acf89b3
      rhenck authored
      9acf89b3
    • rhenck's avatar
      [editor] Add section element list · af1b9ad7
      rhenck authored
      This allows to select elements without clicking them on the canvas, as 
      elements may be obstructed or not visible for some reason.
      
      The selection logic is a bit complicated because usually only the 
      overlay components are usd for selection which are also the place to 
      apply any highlighting on. Here we have to find the component element 
      reference from the section. Therefore the double looping 
      'getElementComponent' method.
      
      Also when an elements is selected it briefly gets z-index 100 so it is 
      moved to the front and visible and manipulatable.
      af1b9ad7
  6. Dec 03, 2021
  7. Dec 02, 2021
  8. Dec 01, 2021
  9. Nov 30, 2021
  10. Nov 29, 2021
  11. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  12. Nov 25, 2021
  13. Nov 24, 2021
    • rhenck's avatar
      Add new general property useMinHeight · b44784b6
      rhenck authored
      Min-height should be optional for dynamically positioned elements, as 
      you usually don't need it and it causes more problems than it solves. 
      Elements with min-height have cause unexpected margins between elements.
      b44784b6
  14. Nov 20, 2021
  15. Nov 19, 2021
Loading