Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  2. Feb 28, 2022
  3. Feb 18, 2022
    • rhenck's avatar
      Refactor style interface · 6237ccb2
      rhenck authored
      - Unify font and surface props
      - Use intersection type for additional properties
      - Also rework editor props panel to properly create the combined 
      properties recursively, passing the results to its child panel (tabs).
      New algorithm works without lodash, therefore the package is removed.
      6237ccb2
  4. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  5. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  6. Jan 20, 2022
  7. Jan 12, 2022
  8. Dec 06, 2021
    • rhenck's avatar
      Fix value of dropLists after drop · 4beec526
      rhenck authored
      Now only sends a list with IDs as value. The actual list manipulation is 
      done with Material helper functions (transferArrayItem...).
      4beec526
  9. Dec 01, 2021
  10. Nov 30, 2021
  11. Nov 29, 2021
    • rhenck's avatar
      Add new element DropListSimple · 1442163d
      rhenck authored
      It is meant to be used as inline positioned (sub) element. Therefore it 
      has not postioning information and less property options than the normal 
      drop list. Similar to the simple text field.
      1442163d
  12. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  13. Nov 19, 2021
  14. Nov 18, 2021
    • rhenck's avatar
      Change dropList styling · 73003562
      rhenck authored
      - List items only have a margin between then but no longer on the 
      outside.
      - Remove unused background color. This is set dynamically in the 
      template.
      73003562
  15. Nov 12, 2021
  16. Nov 10, 2021
  17. Nov 09, 2021
  18. Nov 08, 2021
    • rhenck's avatar
      Add onlyOneItem and orientation property to DropList · 548714cb
      rhenck authored
      Also improve conditional border style. The additional dragPreview is 
      needed so the dragged item does not have the border.
      548714cb
    • rhenck's avatar
      Add styling to DropList and fix sizing · f7f4f77f
      rhenck authored
      The width/height of 90% are a preliminary workaround to not produce 
      overflow with the border. A better solution would be good.
      f7f4f77f
    • rhenck's avatar
      Add new element DropList · 4dda125e
      rhenck authored
      This element has a list of string as editable options. Those strings 
      form draggable elements which may be reordered or moved between 
      different DropList elements.
      
      Also refactor option change logic to allow any property not just the 
      text property.
      4dda125e
Loading