Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Apr 12, 2022
  2. Apr 11, 2022
  3. Mar 17, 2022
  4. Mar 07, 2022
  5. Mar 03, 2022
  6. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  7. Feb 28, 2022
  8. Feb 18, 2022
    • rhenck's avatar
      Refactor style interface · 6237ccb2
      rhenck authored
      - Unify font and surface props
      - Use intersection type for additional properties
      - Also rework editor props panel to properly create the combined 
      properties recursively, passing the results to its child panel (tabs).
      New algorithm works without lodash, therefore the package is removed.
      6237ccb2
  9. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  10. Feb 16, 2022
  11. Feb 11, 2022
  12. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  13. Jan 24, 2022
  14. Dec 16, 2021
  15. Nov 29, 2021
  16. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  17. Nov 24, 2021
    • rhenck's avatar
      Improve styling of cloze sub-elements · 447fa70b
      rhenck authored
      The issue here is the alignment if dropLists and text fields. They are 
      supposed to be exactly in line with the text which is very complicated 
      with Material components, which are heavily nested and contain several 
      sub-elements which need to be changed - removing margins, paddings and 
      other position related styles.
      447fa70b
  18. Nov 22, 2021
  19. Nov 19, 2021
  20. Nov 15, 2021
  21. Nov 10, 2021
    • rhenck's avatar
      Refactor elements to use the model's value · 373108a5
      rhenck authored
      This change mainly helps the editor.
      The idea is to make the element components have the correct value of
      their model and don't rely on the formcontrol value. The formcontrol
      can be hard to manipulate, especially in compound elements. Setting
      the model value is way easier.
      
      The formcontrols are kept and should not interfere.
      373108a5
  22. Oct 29, 2021
  23. Oct 28, 2021
  24. Oct 18, 2021
  25. Oct 15, 2021
  26. Oct 13, 2021
    • rhenck's avatar
      Add classes for all models · 0473666d
      rhenck authored
      - Remove interfaces
      - Add classes for all elements as well as unit, page and section
      - 2 intermediate interfaces are kept. They dont constituate a viable 
      object but only additional properties, like background-color. Those can 
      be added as interface to all elements. Initialisation has to be done by 
      the element itself though and not by some constructor higher up.
      0473666d
  27. Oct 07, 2021
  28. Sep 30, 2021
    • jojohoch's avatar
      [player] Refactor validation messages · 4005b51e
      jojohoch authored
      * Delete validation message component
      * Use instead `mat-error` inside element components to take advantage
       of `mat-input-field`
      * Add get validators method to each form element component
      * Display validation messages via `error-transform` pipe
      4005b51e
  29. Sep 29, 2021
    • rhenck's avatar
      Fix background color of input fields · c1d22c87
      rhenck authored
      Since the material elements don't give a way of applying the background 
      color, a hack is needed to get the internal elements and apply the 
      style.
      
      Directive to be able to do it for text field and text area.
      c1d22c87
  30. Sep 22, 2021
  31. Sep 21, 2021
Loading