Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. May 05, 2022
  2. Apr 14, 2022
  3. Apr 01, 2022
  4. Mar 30, 2022
    • rhenck's avatar
      [editor] Fix likert element · df267cc0
      rhenck authored
      There were several issues with it's properties, which could not be 
      changed.
      Now it is properly initialized and prop change get actually handled.
      df267cc0
  5. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  6. Feb 21, 2022
    • rhenck's avatar
      Refactor properties panel · 53ef919f
      rhenck authored
      - Use sub components to reduce the size of the templates
      - Introduce field sets for input groups like dimensions and position
      - Improve logic to determine when to show some fields
      53ef919f
  7. Feb 18, 2022
    • rhenck's avatar
      Refactor style interface · 6237ccb2
      rhenck authored
      - Unify font and surface props
      - Use intersection type for additional properties
      - Also rework editor props panel to properly create the combined 
      properties recursively, passing the results to its child panel (tabs).
      New algorithm works without lodash, therefore the package is removed.
      6237ccb2
  8. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  9. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  10. Jan 20, 2022
    • rhenck's avatar
      [editor] Disable font field · 2e1d13d7
      rhenck authored
      Since we can't safely assume any other font than the one we ship is 
      available, it is better to not allow changing this.
      
      I have not removed the variable completely as in the futire more than 
      one font might be wanted. So for now you just can't choose another.
      2e1d13d7
  11. Dec 14, 2021
    • rhenck's avatar
      [editor] Refactor color inputs · d67ba751
      rhenck authored
      Use a suffix button to activate color picker instead of having an extra 
      form field.
      
      Also add direct input for likert line coloring color.
      d67ba751
  12. Dec 09, 2021
  13. Nov 30, 2021
    • rhenck's avatar
      [editor] Fix properties panel with multiselect · 5d575326
      rhenck authored
      The change of moving some properties to sub objects broke the creation 
      of the combinedProperties object, which can't deal with nested objects. 
      To circumvent that all elements are now flattened before being combined.
      The connected property panels now again look for the properties on the 
      element itself and not in sub-objects.
      5d575326
  14. Nov 29, 2021
  15. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  16. Nov 11, 2021
  17. Nov 05, 2021
  18. Nov 02, 2021
  19. Oct 28, 2021
  20. Oct 18, 2021
    • rhenck's avatar
      [editor] Refactor directory structure · 9f65f0c9
      rhenck authored
      The main components are right at top level and the directories below
      mimic the data structure (unit->page->section).
      The toolbar is only used in dev mode and does not belong directly to the
      unit view.
      The TextEditor is a complex component and deserves it's own directory
      even though it is used within the unit-view. Might be refactored to its
      own module later.
      9f65f0c9
  21. Oct 15, 2021
  22. Oct 13, 2021
  23. Oct 07, 2021
Loading