Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Jul 05, 2023
    • rhenck's avatar
      Fix merge issues · 2a0859f0
      rhenck authored
      2a0859f0
    • rhenck's avatar
      Refactor element model constructors and styling properties · 53f887fa
      rhenck authored
      - Model constructors (elements, unit, page, section) now have a 
      dedicated parameter, which makes sure all properties are set and valid. 
      This way the player can instantiate models without having to interpret 
      the values. Any interpretation is done only by the editor, which now is 
      solely responsible for creating defaults/blueprints for new elements. 
      Models can no longer be created by incomplete paramaters.
      
      - Also refactor Stylings to have sub groups for common styles
      53f887fa
  2. Jun 30, 2023
    • rhenck's avatar
      Refactor PositionProperties · 7f571ddf
      rhenck authored
      - Remove dynamicPositioning from PositionProperties. This is not 
      knowledge that the element needs to know. In the few places it was used, 
      it was fixed or solved by asking the containing section about which 
      positioning is active.
      
      - Fix and improve cloze child sizing. All can now have dynamic width and 
      height.
      
      - Fix empty lines in ClozeDocument rendering
      
      - Editor SelectionService now knows if a cloze child is selected. This 
      way the PropertiesPanel can show valid dimension inputs regardless of 
      the underlying section.
      7f571ddf
  3. Jun 27, 2023
  4. Jun 26, 2023
  5. Jun 23, 2023
  6. Jun 15, 2023
  7. May 24, 2023
  8. Nov 29, 2022
  9. Nov 07, 2022
    • rhenck's avatar
      Re-implement DropList element · 6d1ad52c
      rhenck authored
      - Replace Material Droplist with native HTML events
      - Remove simple-drop-list element; Cloze elements now use the normal 
      DropList element
      - Add example units
      6d1ad52c
  10. Oct 21, 2022
    • jojohoch's avatar
      Implement HotspotImage · b174d3a2
      jojohoch authored
      - A HotspotImage has an image and divs placed on it, which are used
      as hotspots
      - Inherits from FormElementComponent, which is why the hotspots are kept
        as a list in the value property.
      - Can be validated as required and uses its own custom validator
      b174d3a2
  11. Oct 17, 2022
    • rhenck's avatar
      Rework Elementfactory · 0c0b9e3b
      rhenck authored
      The unit tests errored out because of circular dependencies via the 
      Elementfactory class. Therefore:
      - No longer creates styling/position/player-Properties. This is done in 
      the Element parent class.
      - Move element creation from Section to the ElementFactory class 
      instead.
      0c0b9e3b
  12. Oct 14, 2022
  13. Oct 13, 2022
  14. Oct 07, 2022
  15. Sep 21, 2022
  16. Sep 15, 2022
    • rhenck's avatar
      Rework ID handling · 0e45e323
      rhenck authored
      - remove ID handling from model classes. This is now done by the editor 
      itself (mainly unit service).
      - Rename and move IDManager to editor as IDService
      0e45e323
  17. Aug 29, 2022
  18. Aug 10, 2022
  19. Aug 09, 2022
  20. Jun 28, 2022
  21. Jun 14, 2022
  22. Jun 03, 2022
  23. Jun 02, 2022
  24. Jun 01, 2022
    • rhenck's avatar
      Fix simple drop list properties panel · f63443af
      rhenck authored
      Now properly finds all normal and simple drop lists.
      This is achieved by a new method of unit all it's sub-components, which 
      returns all contained elements with and optional type filter.
      
      Also improve (still not very pretty) styling of the drop list props 
      panel.
      
      #260 #259
      f63443af
    • rhenck's avatar
      Rework class initialization · f28b0678
      rhenck authored
      - Elements initialize their fields explicitly and not with
        Object.assign, since Object.assign also assigns
        (and therefore overwrites) parent fields.
      - IDService is no longer an Angular service but a basic singleton. This
        allows to use it in classes.
      - The IDManager can be optionally passed to unit and element
        constructors. When present the elements check and fix their given ID
        when created.
        This way elements can be created without depending on the external
        IDManager but also with the dependency.
      - ElementFactory is no longer used to create elements. Those are now
        either created directly via 'new' or via the Section, which knows the
        different element types.
      f28b0678
  25. May 18, 2022
  26. May 17, 2022
    • rhenck's avatar
      Refactor model interfaces to classes · 2e9be6e9
      rhenck authored
      This way elements can handle their logic themselves without having to
      rely on outside utility classes.
      
      Also restructure files in common in a more logical way.
      2e9be6e9
  27. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  28. Dec 17, 2021
    • rhenck's avatar
      [editor] Fix element alignment · 5269a5f4
      rhenck authored
      - Move the method to the unit service, so the proper 
      updateElementProperty method can be used.
      - Also improve the logic, reducing variables.
      5269a5f4
  29. Dec 10, 2021
    • rhenck's avatar
      Refactor ElementFactory to abstract class · 33e72a0b
      rhenck authored
      This makes for cleaner imports.
      33e72a0b
    • rhenck's avatar
      [editor] Fix element duplication · 2e743910
      rhenck authored
      Was not correctly creating new instances of non-primitive values. Now
      uses "JSON.parse(JSON.stringify(element))" for deep copying the element
      first.
      
      Also refactor by moving the method to the UnitService, where all ID
      handling should take place.
      2e743910
  30. Dec 02, 2021
    • rhenck's avatar
      Switch to Partials for serializedElements · 606c392f
      rhenck authored
      The given serialized properties may not conform to all UIElement 
      properties. They are merely meant as a building plan; they may also 
      contain outdated properties which have to be transformed when reading.
      606c392f
  31. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
Loading