Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Feb 02, 2024
  2. Aug 01, 2023
  3. Jul 28, 2023
  4. Jul 25, 2023
    • rhenck's avatar
      Rework ClozeElement document parsing · da7f46a4
      rhenck authored
      The ClozeDocument needs properly instantiated UIElements for the custom 
      elements.
      Instead of creating a new ClozeDocument on the basis of what TipTap is 
      producing and replacing the custom parts with instances, the 
      ClozeDocument is kept in place but the custom parts are collected into a 
      list and changed there.
      
      #450
      da7f46a4
  5. Jul 24, 2023
    • rhenck's avatar
      Rework class constructors · 81de7c0f
      rhenck authored
      In Player-context the constructors are to fail, when the given 
      properties are not exactly as expected. Therefoore they are validated. 
      When this validation fails, an environment variable is checked to 
      determine if the element should be created anyway with defaults. This 
      switch is off in player-context. But the Editor is not so strict and can 
      create elements with incomplete parameters.
      
      There is also a new VersionManager which checks given unit definitions 
      for version-validity. Upon failing this check Player and Editor show 
      error messages.
      The Editor accepts a certain unit definition version, but shows a 
      warning.
      
      The Editor checks units for invalid references after loading. If any are 
      found, they are removed and an info-panel is shown.
      81de7c0f
  6. Jul 05, 2023
    • rhenck's avatar
      Refactor element model constructors and styling properties · 53f887fa
      rhenck authored
      - Model constructors (elements, unit, page, section) now have a 
      dedicated parameter, which makes sure all properties are set and valid. 
      This way the player can instantiate models without having to interpret 
      the values. Any interpretation is done only by the editor, which now is 
      solely responsible for creating defaults/blueprints for new elements. 
      Models can no longer be created by incomplete paramaters.
      
      - Also refactor Stylings to have sub groups for common styles
      53f887fa
  7. Jun 30, 2023
    • rhenck's avatar
      Refactor PositionProperties · 7f571ddf
      rhenck authored
      - Remove dynamicPositioning from PositionProperties. This is not 
      knowledge that the element needs to know. In the few places it was used, 
      it was fixed or solved by asking the containing section about which 
      positioning is active.
      
      - Fix and improve cloze child sizing. All can now have dynamic width and 
      height.
      
      - Fix empty lines in ClozeDocument rendering
      
      - Editor SelectionService now knows if a cloze child is selected. This 
      way the PropertiesPanel can show valid dimension inputs regardless of 
      the underlying section.
      7f571ddf
  8. Jun 15, 2023
  9. Dec 13, 2022
  10. Dec 12, 2022
  11. Nov 07, 2022
    • rhenck's avatar
      Re-implement DropList element · 6d1ad52c
      rhenck authored
      - Replace Material Droplist with native HTML events
      - Remove simple-drop-list element; Cloze elements now use the normal 
      DropList element
      - Add example units
      6d1ad52c
  12. Oct 25, 2022
  13. Oct 07, 2022
  14. Jun 01, 2022
    • rhenck's avatar
      Refactor cloze element's document handling · 89befccd
      rhenck authored
      - Move methods from cloze parser helper library to cloze class.
      - Cloze children are set up with a special placeholder which is then 
      recognized and replaced by a new ID. And the element is recreated (like 
      before) to have a proper element model class, which the TipTap editor 
      doesn't provide.
      89befccd
    • rhenck's avatar
      Rework class initialization · f28b0678
      rhenck authored
      - Elements initialize their fields explicitly and not with
        Object.assign, since Object.assign also assigns
        (and therefore overwrites) parent fields.
      - IDService is no longer an Angular service but a basic singleton. This
        allows to use it in classes.
      - The IDManager can be optionally passed to unit and element
        constructors. When present the elements check and fix their given ID
        when created.
        This way elements can be created without depending on the external
        IDManager but also with the dependency.
      - ElementFactory is no longer used to create elements. Those are now
        either created directly via 'new' or via the Section, which knows the
        different element types.
      f28b0678
  15. May 17, 2022
    • rhenck's avatar
      Refactor model interfaces to classes · 2e9be6e9
      rhenck authored
      This way elements can handle their logic themselves without having to
      rely on outside utility classes.
      
      Also restructure files in common in a more logical way.
      2e9be6e9
  16. May 02, 2022
    • rhenck's avatar
      Refactor simple elements for cloze · 28ead292
      rhenck authored
      - Split text field and drop list, so they can have differing props
      - Improve their dimension default values
      - Improve alignment of all cloze children components
      - Add dynamic width parameter of toggle buttons to dimension properties
      panel. Therefore the postion tab can always be shown and no longer needs
      a condition.
      28ead292
  17. Apr 19, 2022
  18. Apr 14, 2022
  19. Mar 07, 2022
  20. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  21. Feb 28, 2022
  22. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  23. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  24. Jan 12, 2022
Loading