Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Oct 18, 2022
  2. Oct 07, 2022
  3. Sep 09, 2022
  4. Sep 08, 2022
  5. Aug 30, 2022
  6. Aug 08, 2022
  7. Jun 03, 2022
    • rhenck's avatar
      Fix drag and drop with images · 781568b0
      rhenck authored
      The dragged image did contain carry information about it's element.
      Also remove useless drag and drop functionality for the placeholder.
      781568b0
  8. May 17, 2022
    • rhenck's avatar
      Refactor model interfaces to classes · 2e9be6e9
      rhenck authored
      This way elements can handle their logic themselves without having to
      rely on outside utility classes.
      
      Also restructure files in common in a more logical way.
      2e9be6e9
  9. May 05, 2022
    • rhenck's avatar
      Refactor droplist · abca027e
      rhenck authored
      - Fix DropLists with copyOnDrop to display a placeholder copy of
      dragged elements.
      The drop preview is hidden on those lists. It still has to be in the DOM
      to be the target for the 'falling' animation of the dragged item,
      otherwise it flies to the top left corner of the viewport.
      abca027e
  10. May 02, 2022
    • rhenck's avatar
      Implement copy on drop for dropLists · c6f4e3f2
      rhenck authored
      With this setting elements are copied when being dropped to another 
      list.
      
      On drop it is also checked if the item-ID is already present in the 
      list. If it is the drop event is silently discarded. This allows putting 
      items back in the list without creating duplicate IDs.
      
      Lists with this setting:
      - do show a placeholder of the items being dragged. This way it is 
      conveyed that the item will remain there after being dropped.
      - don't show a placeholder when items are hovered over them, to avoid 
      confusion with duplicate items.
      
      Sorting within DropLists is disabled, since it causes moving items 
      within the list. It has to be discussed if this feature is even needed.
      c6f4e3f2
  11. Apr 19, 2022
  12. Apr 05, 2022
  13. Mar 31, 2022
  14. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  15. Feb 28, 2022
  16. Feb 18, 2022
    • rhenck's avatar
      Refactor style interface · 6237ccb2
      rhenck authored
      - Unify font and surface props
      - Use intersection type for additional properties
      - Also rework editor props panel to properly create the combined 
      properties recursively, passing the results to its child panel (tabs).
      New algorithm works without lodash, therefore the package is removed.
      6237ccb2
  17. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  18. Feb 16, 2022
  19. Feb 11, 2022
  20. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  21. Dec 16, 2021
    • rhenck's avatar
      Add fixedSize styling to most elements · 27b284c7
      rhenck authored
      Elements are supposed to be centred when this setting is used. Since it 
      is the same CSS for almost all element components it is put into global 
      styles.
      
      Missing components: video, spelling.
      27b284c7
  22. Dec 15, 2021
    • rhenck's avatar
      Make dropList reserve some space for outline · b5060f28
      rhenck authored
      Outline may be shown when valid dropLists are highlighted. The bottom 
      patr of the outline is cut off when the whole width is used by the 
      dropList.
      b5060f28
    • rhenck's avatar
      Fix fixed sized element positioning · 70c13b45
      rhenck authored
      Section was picking up the size of children elements. With relative it 
      works.
      70c13b45
    • rhenck's avatar
      Add new position property 'fixedSize' · 47b96d9b
      rhenck authored
      This allows elements in dynamic sections to have fixed dimensions.
      
      Some modifications to property panel logic, to show dimension fields and
      proper labels.
      
      Only implmented in dropList and button elements.
      47b96d9b
  23. Dec 13, 2021
    • rhenck's avatar
      Add flex orientation for dropList · 6dd9ba11
      rhenck authored
      This new setting makes child items space around in a row with line 
      break.
      
      Images in vertical alignment now always reserve the whole row and don't 
      appear next to each other.
      6dd9ba11
  24. Dec 06, 2021
    • rhenck's avatar
      Fix value of dropLists after drop · 4beec526
      rhenck authored
      Now only sends a list with IDs as value. The actual list manipulation is 
      done with Material helper functions (transferArrayItem...).
      4beec526
  25. Dec 03, 2021
  26. Dec 01, 2021
  27. Nov 30, 2021
  28. Nov 29, 2021
    • rhenck's avatar
      Fix drag and drop element cursor style (in player) · 42b09cc0
      rhenck authored
      This is the same hack used in the editor for overlay elements. Here 
      applied to the actual dnd elements seen in the player.
      
      Explanation: The cursor can not be applied to the dragged elements as it 
      is not positioned (at least that is my understanding). The workaround is 
      to style the body (cursor) while anything is being dragged.
      42b09cc0
  29. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  30. Nov 19, 2021
  31. Nov 18, 2021
    • rhenck's avatar
      Change dropList styling · 73003562
      rhenck authored
      - List items only have a margin between then but no longer on the 
      outside.
      - Remove unused background color. This is set dynamically in the 
      template.
      73003562
Loading