Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. Apr 19, 2022
  2. Apr 14, 2022
  3. Mar 31, 2022
  4. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  5. Feb 28, 2022
  6. Feb 22, 2022
  7. Feb 18, 2022
    • rhenck's avatar
      Refactor style interface · 6237ccb2
      rhenck authored
      - Unify font and surface props
      - Use intersection type for additional properties
      - Also rework editor props panel to properly create the combined 
      properties recursively, passing the results to its child panel (tabs).
      New algorithm works without lodash, therefore the package is removed.
      6237ccb2
  8. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  9. Feb 16, 2022
  10. Feb 11, 2022
  11. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  12. Jan 22, 2022
    • rhenck's avatar
      Fix paths · e27660f9
      rhenck authored
      e27660f9
    • rhenck's avatar
      Fix and refactor cloze compat handling · e58147db
      rhenck authored
      Now correctly creates child elements for every marker it finds.
      
      Updated the TipTap extensions to use model instead of just the ID.
      
      Also improve interface naming.
      e58147db
  13. Jan 21, 2022
  14. Jan 20, 2022
  15. Jan 19, 2022
    • rhenck's avatar
      Rework compound child components · 87effdf7
      rhenck authored
      Compound elements are now supposed to use overlays for their child
      elements. This overlay makes selecting child components (by clicking on
      them) and marking them as selected (done by the selection service)
      possible.
      The SelectionService no longer needs special logic to handle compound
      children selection, as they now also have an overlay with the same
      interface as normal (canvas) elements.
      
      A few modifications in connected directives are necessary. The now
      handle children components in a proper array instead of QueryList.
      
      Likert elements do not have clickable children yet and work a little
      differently. This should probably be unitized in the future.
      87effdf7
  16. Jan 17, 2022
  17. Jan 12, 2022
    • rhenck's avatar
      Rework cloze element data · 15cdca5e
      rhenck authored
      - Now only has a variable 'document'. This holds the HTML representation
        in an object. This object is enriched with element models.
      - Because the the TextEditor extension can neither create multiple
        element instances nor use the IDService to generate their IDs, this
        has to be done afterwards. See ClozeParser.
      - The cloze element has rather extensive compatibility handling because
        cloze elements used to save an actual HTML representation. This has to
        be transformed to JSON/object. Therefore we replace the old backslash-
        markers with custom HTML tags. The editor object does this
        transformation. It needs some custom extensions to recognize (and
        don't remove) the HTML tags though.
      - Cloze now shows a placeholder text when empty
      - The cloze component needs a small pipe to extract text formatting
        options from the paragraph parts.
      - For getting the child elements for the player the models have to be
        extracted from the somewhat complex (JSON)document.
      - Added some rudimentary interfaces for the TextEditor document format.
      - Removed the old ClozePart interface. This is quasi part of the new
        interfaces.
      15cdca5e
  18. Dec 16, 2021
    • rhenck's avatar
      Add fixedSize styling to most elements · 27b284c7
      rhenck authored
      Elements are supposed to be centred when this setting is used. Since it 
      is the same CSS for almost all element components it is put into global 
      styles.
      
      Missing components: video, spelling.
      27b284c7
  19. Dec 10, 2021
    • rhenck's avatar
      Move ID-Service to editor · 03e8c00b
      rhenck authored
      Generally only the editor needs to generate new IDs. Before there was
      need to have it in common because some elements (like compound elements)
      needed to generte new Elements including IDs.
      Now all ID stuff is handled by the UnitService and the elements classes
      are handed the fully built elements. Unfortunately this means that some
      logic has to move back from classes into the UnitService. To un-bloat
      the UnitService a (and in the future some more) helper class is created
      for this logic.
      
      The most important thing is, that the UIElement no longer generates
      an ID when created. The ID has to be created before and passed to the
      constructor.
      03e8c00b
  20. Dec 07, 2021
  21. Dec 01, 2021
  22. Nov 29, 2021
  23. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  24. Nov 25, 2021
    • rhenck's avatar
      Add new element TextFieldSimple · 751a65fe
      rhenck authored
      This is a native input element which is used in cloze elements. Here 
      (sub)elements need to be positioned inline, which is hard to do with 
      material components.
      
      Also add a method to all form elements to set their form value, which is 
      now only used by the simple text field but may be useful for other 
      elements, which don't integrate in material form fields.
      751a65fe
  25. Nov 24, 2021
    • rhenck's avatar
      Improve styling of cloze sub-elements · 447fa70b
      rhenck authored
      The issue here is the alignment if dropLists and text fields. They are 
      supposed to be exactly in line with the text which is very complicated 
      with Material components, which are heavily nested and contain several 
      sub-elements which need to be changed - removing margins, paddings and 
      other position related styles.
      447fa70b
  26. Nov 23, 2021
  27. Nov 22, 2021
  28. Nov 20, 2021
  29. Nov 19, 2021
Loading