Skip to content
Snippets Groups Projects
This project is mirrored from https://*****@github.com/iqb-berlin/verona-modules-aspect.git. Pull mirroring updated .
  1. May 27, 2024
  2. May 26, 2024
    • rhenck's avatar
      [editor-ui] Rework page menu · d0af963a
      rhenck authored
      - Encapsule into separate component
      - No more pop-in-controls
      - slicker ui layout
      - More tooltip with explanations
      d0af963a
  3. Aug 03, 2023
  4. Jul 24, 2023
    • rhenck's avatar
      Rework class constructors · 81de7c0f
      rhenck authored
      In Player-context the constructors are to fail, when the given 
      properties are not exactly as expected. Therefoore they are validated. 
      When this validation fails, an environment variable is checked to 
      determine if the element should be created anyway with defaults. This 
      switch is off in player-context. But the Editor is not so strict and can 
      create elements with incomplete parameters.
      
      There is also a new VersionManager which checks given unit definitions 
      for version-validity. Upon failing this check Player and Editor show 
      error messages.
      The Editor accepts a certain unit definition version, but shows a 
      warning.
      
      The Editor checks units for invalid references after loading. If any are 
      found, they are removed and an info-panel is shown.
      81de7c0f
  5. Jun 27, 2023
  6. Jun 13, 2023
    • rhenck's avatar
      [editor] Add reference checker · 0b27b48c
      rhenck authored
      - Add ReferenceManager to check if deleted elements are referenced 
      anywhere in the unit. If so display a warning.
      - Move page logic to UnitService
      0b27b48c
  7. Aug 01, 2022
  8. May 17, 2022
    • rhenck's avatar
      Refactor model interfaces to classes · 2e9be6e9
      rhenck authored
      This way elements can handle their logic themselves without having to
      rely on outside utility classes.
      
      Also restructure files in common in a more logical way.
      2e9be6e9
  9. Apr 14, 2022
  10. Mar 04, 2022
  11. Mar 02, 2022
    • rhenck's avatar
      Refactor unit definition and sanatizer · 874c1af3
      rhenck authored
      - Units and element are now built via the factory. This ensures only the
        wanted properties are present. All others are discarded.
      - Since the sanatizer is supposed to check the unit defintion version
        it is used by player and editor and therefore put in common.
        This in turn makes it necessary to put the JSON resolver settings
        in the root-TSConfig file.
      - Renamed a couple of properties to have clearer names.
      874c1af3
  12. Feb 28, 2022
  13. Feb 22, 2022
    • rhenck's avatar
      [editor] Refactor page view component · d67f72f7
      rhenck authored
      - Now does unit (page) manipulation itself instead of delegating 
      everything to the UnitService. Still need to call the UnitService to 
      make it notify the API about the change to the unit.
      - Also improve the hack for refreshing the tab view.
      d67f72f7
    • rhenck's avatar
      [editor] Remove page view component · 973ab396
      rhenck authored
      It did not do anyhting anyway. Is now integrated in unit view.
      973ab396
  14. Feb 17, 2022
    • rhenck's avatar
      Rework models from classes to interfaces · f416ce14
      rhenck authored
      This removes all the classes and goes back to simple interfaces for
      unit, pages etc and all elements. This makes creating them easier and
      cleaner.
      Things like specific needs when setting element properties and most
      importantly compatibility handling is done by a special service module,
      that knows all the elements and how to repair old their potentially
      outdated definitions.
      f416ce14
  15. Feb 09, 2022
    • rhenck's avatar
      Change all selector prefixes from "app" to "aspect" · a6bdf445
      rhenck authored
      This is done according to the Angular best practices and minimizes
      namespace collisions when using other packages which might use the same
      selectors.
      
      Technically the selectors are not even becessary since we use an Angular
      component factory to create element components but it is still useful
      for the DOM element naming, for debugging purposes for example.
      a6bdf445
  16. Dec 13, 2021
  17. Dec 10, 2021
    • rhenck's avatar
      [editor] Refactor unit service · 53f4e848
      rhenck authored
      No longer have unit as subject. Components can use the unit variable as 
      is and still get updated.
      This removes some listener stuff in conected components.
      53f4e848
  18. Nov 26, 2021
    • rhenck's avatar
      Refactor element class and interface structure · 4a413b60
      rhenck authored
      The problem being solved is that compound-sub-elements must not have
      all the properties other elements have. For exampe positioning info.
      Sub-Elements are positioned inline. To avoid having similar class
      inheritance structures for positioned and inline elements, we use
      interface. Positioning is done via interface and is therefore optional.
      
      Those optional properties are kept in an object in a variable. This
      allows to hide specifics from element classes and removes the need to
      initialize all the fields in every class using the interface.
      The elements mostly care about their own specific properties anyway.
      
      The same technique is used for font and surface elements. Here we also
      don't want to initialize all the styles in every class.
      
      Changing values of element properties works like before. Just set the
      property as if it would be a direkt prop of the element. The element
      itself puts the value in the currect sub-object (positioningProps,
      fontProps etc).
      
      For reading the values there is a similar method, but it is not used
      anywhere by now. Since the properties panel operates on the raw values
      anyway (refer CombinedProperties) and for element components this would
      mean calling a function in the template, which caused change detection
      to run the function very often and is therefore bad practice.
      
      Additional notes and refactorings:
      - Restructure all files in common. UIElements in the same folder etc.
      - Move all interfaces to the UIElement file. This avoids circular
        imports, which would be needed to allow PositionedElement to extend
        UIElement.
      - Interface initializers also handle reading values in the old form.
      - Add PositionedElement for use in canvas overlays. This is a UIElement
        with guaranteed postionProps.
      - Don't export all Material packages from common, only the ones
        used in player and editor. The rest is only used in common and
        does not need to be exported.
      4a413b60
  19. Nov 11, 2021
    • rhenck's avatar
      [editor] Refactor directory structure and separate dialog components · cc549202
      rhenck authored
      This structure moves closer to the structure template the team decided
      on. Components and services are kept in dedicated folders instead of
      following the logical code structure. This is still not the case here as
      the unit-view component is still nested, but it's closer.
      cc549202
  20. Nov 08, 2021
  21. Nov 01, 2021
  22. Oct 29, 2021
  23. Oct 18, 2021
    • rhenck's avatar
      [editor] Refactor directory structure · 9f65f0c9
      rhenck authored
      The main components are right at top level and the directories below
      mimic the data structure (unit->page->section).
      The toolbar is only used in dev mode and does not belong directly to the
      unit view.
      The TextEditor is a complex component and deserves it's own directory
      even though it is used within the unit-view. Might be refactored to its
      own module later.
      9f65f0c9
  24. Oct 15, 2021
  25. Oct 13, 2021
  26. Sep 26, 2021
    • rhenck's avatar
      [editor] Improve code style · 04d2d93d
      rhenck authored
      04d2d93d
    • rhenck's avatar
      [editor] Refactor selection logic · df0a6139
      rhenck authored
      - The selection service only needs to handle element selection. For
      pages and sections having the index is enough.
      - Those indeces are simple fields instead of observables. This also
      simplifies the components which don't have to get the value out of the
      observables.
      - Therefore the selection service does no longer need to have a direct
      reference to the unit service and it's unit.
      - Selection logic is not done by the section components themselves but
      by the parent canvas component.
      - The unit service can now manipulate pages and section by index in
      addition to passing the necessary objects directly.
      df0a6139
  27. Sep 24, 2021
  28. Sep 21, 2021
  29. Sep 20, 2021
  30. Sep 17, 2021
  31. Sep 16, 2021
  32. Aug 16, 2021
    • rhenck's avatar
      [editor] Minor refactoring · 69054e2a
      rhenck authored
      Unsubscribing, private methods ...
      69054e2a
    • rhenck's avatar
      Refactor unit service and selection service · 9b525650
      rhenck authored
      - Unit service now again takes the elements to be changed as parameter
      instead of managing (and even knowing) selections.
      - Selections are managed by the appropriate service
      - Also using rxjs operators instead of serving observable state as
      getter method.
      9b525650
  33. Aug 03, 2021
    • rhenck's avatar
      [editor] Massively refactor unit and page view · 99094fd3
      rhenck authored
      - ... mostly for dynamic positioning
      - Refactor reordering of sections. They can now be moved by small
      buttons to the side, which appear when hovering. The section edit mode
      is no longer available. -> KISS
      - Removed all toolbars. The props can now be set via the props panel,
      which now has sections for pages, sections and elements. This is to have
      more vertical space available for editing the unit.
      - Sections can now (only) be added via the toolbox panel, where the
      second tab is now exclusively for sections. Future templates are
      supposed to be whole sections, which can also be added from there.
      - Refactor CSS layouting (flex and co) to have better handling of
      vertically growing page (via sections)
      - Some preparation for an upcoming overhaul of selection stuff
      (again :))
      99094fd3
Loading